Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Querier and Query Frontend to run in the same process #4218

Closed
trevorwhitney opened this issue Aug 25, 2021 · 0 comments · Fixed by #4301
Closed

Allow Querier and Query Frontend to run in the same process #4218

trevorwhitney opened this issue Aug 25, 2021 · 0 comments · Fixed by #4301
Assignees

Comments

@trevorwhitney
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When running a single-binary instance of Loki, if both the querier and query frontend targets are enabled, then they register the same routes and step on each other.

Describe the solution you'd like
Implement the solution from cortex that uses an internal query server that is optionally registered publicly when only one target is registered, or is referenced internally when both are registered.

Describe alternatives you've considered
Haven't really though of many alternative since this is already done in cortex and should be pretty easy to bring over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant