Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context cancelled should not return 500 on the querier. #4502

Closed
cyriltovena opened this issue Oct 20, 2021 · 0 comments · Fixed by #4593
Closed

Context cancelled should not return 500 on the querier. #4502

cyriltovena opened this issue Oct 20, 2021 · 0 comments · Fixed by #4593
Labels
type/bug Somehing is not working as expected

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Oct 20, 2021 •
edited
Loading 

level=warn ts=2021-10-20T09:50:59.04540617Z caller=logging.go:72 traceID=32bc4c6c5c7c1cf1 orgID=22473 msg="GET /loki/api/v1/query_range? (500) 212.977598ms Response: \"2 errors: rpc error: code = Canceled desc = context canceled; rpc error: code = Canceled desc = context canceled\\n\" ws: false; X-Scope-Orgid: 22473; uber-trace-id: 32bc4c6c5c7c1cf1:5e4560c5826065fc:19a66df0fa59f685:1;

Saw this in the log and we should turn those into 499 instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect gRPC context error when handling errors taisho6339/loki
2 participants
@chaudum @cyriltovena