Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Zstd compression #4620

Closed
cyriltovena opened this issue Nov 3, 2021 · 2 comments
Closed

Test Zstd compression #4620

cyriltovena opened this issue Nov 3, 2021 · 2 comments
Labels
component/storage need-investigation stale A stale issue or PR that will automatically be closed.

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Nov 3, 2021

From my understanding the ztsd decoder and encoder uses goroutines. This means when a decoder/encoder is pooled and will be garbage collected, but when release we don't call close and so we don't stop goroutines

We tried to add this finalizer https://github.com/grafana/loki/blob/main/pkg/chunkenc/pool.go#L235 from #3306 but we didn't for the encoder.

But I'm wondering if we should may be find another solution, possible this can cause go-routines leak even with a finalizer

Alternatively if there's still issues:

  • Investigate if we can't refactor pooling to guarantee call to Close once release/GC. (May be use LRU / custom free list ?)
  • Benchmark change if we do refactoring.
@kavirajk
Copy link
Contributor

kavirajk commented Nov 3, 2021

@stale
Copy link

stale bot commented Jan 9, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 9, 2022
@stale stale bot closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage need-investigation stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

2 participants