Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Loki config management #520

Closed
cyriltovena opened this issue Apr 26, 2019 · 4 comments
Closed

Improve Loki config management #520

cyriltovena opened this issue Apr 26, 2019 · 4 comments
Labels

Comments

@cyriltovena
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently Loki configs file are not superseded by command line flags except for limits but limit
cannot be partially provided and fulfilled by default.

Describe the solution you'd like
Viper from https://github.com/spf13/viper could allow us to have correct order of config precedence with extra features like sane defaults and config reload. This should be fine to integrate even if cortex uses golang flag, viper support also it.

Additional context
#519
#518
https://github.com/cortexproject/cortex/blob/master/pkg/util/validation/limits.go#L65-L73

@daixiang0
Copy link
Contributor

Is there any plan about promtail config?
Now i set a watch in this PR to reload config, if change to viper, would be easy.

@CyrilPeponnet
Copy link
Contributor

+1 logcli / promtail and loki should be consistent and use viper / cobra to handle args / env var and config file.

@daixiang0
Copy link
Contributor

some disguss on slack

@sh0rez
Copy link
Member

sh0rez commented Sep 26, 2019

Implemented in #980

@sh0rez sh0rez closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants