Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixins: templatize cluster label name. #6352

Closed
hervenicol opened this issue Jun 9, 2022 · 1 comment · Fixed by #6353 or #6383
Closed

mixins: templatize cluster label name. #6352

hervenicol opened this issue Jun 9, 2022 · 1 comment · Fixed by #6353 or #6383

Comments

@hervenicol
Copy link
Contributor

Is your feature request related to a problem? Please describe.

My Prometheus setup selects data from a specific cluster thanks to a cluster_id label.
The Loki mixins use a hardcoded cluster label.
I would like to be able to configure this when generating the dashboards.

Describe the solution you'd like
mixins are meant to templatize dashboards creation, so I think we could have a 'per_cluster_label' in config.jsonnet file, to select the label name according to our setup.
That would be quite similar to what is done on kubernetes-mixins here: https://github.com/kubernetes-monitoring/kubernetes-mixin#multi-cluster-support

Describe alternatives you've considered
Apart from dirty forking, not much.

Additional context
N/A

@hervenicol
Copy link
Contributor Author

PR reverted here: #6377
Will create a new (and hopefully better) PR.
@kavirajk , can you please reopen the issue? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant