Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add toleration for bloom components #12653

Merged
merged 3 commits into from
Apr 19, 2024
Merged

feat: add toleration for bloom components #12653

merged 3 commits into from
Apr 19, 2024

Conversation

EvertonSA
Copy link
Contributor

@EvertonSA EvertonSA commented Apr 17, 2024 •
edited
Loading

What this PR does / why we need it:
Adding tolerations to bloom components.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@EvertonSA EvertonSA requested a review from a team as a code owner April 17, 2024 13:18
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

MichelHollands
MichelHollands approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit fcb2b0a into grafana:main Apr 19, 2024
16 checks passed
This was referenced Apr 22, 2024
Closed
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@EvertonSA @MichelHollands
feat: add toleration for bloom components (grafana#12653)
ae5cb71 
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm feature/blooms size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EvertonSA @CLAassistant @MichelHollands @JStickler