From dd44a5db1f056dbab203d4eaa153026bddc96b37 Mon Sep 17 00:00:00 2001 From: michaelgrigoryan25 <56165400+michaelgrigoryan25@users.noreply.github.com> Date: Fri, 10 Jun 2022 13:47:22 +0000 Subject: [PATCH 1/2] cmd/loki: minor consistency patch --- cmd/loki/main.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/cmd/loki/main.go b/cmd/loki/main.go index 1a7028ab07ab4..b81470666a5d0 100644 --- a/cmd/loki/main.go +++ b/cmd/loki/main.go @@ -47,22 +47,19 @@ func main() { // Validate the config once both the config file has been loaded // and CLI flags parsed. - err := config.Validate() - if err != nil { + if err := config.Validate(); err != nil { level.Error(util_log.Logger).Log("msg", "validating config", "err", err.Error()) os.Exit(1) } if config.PrintConfig { - err := util.PrintConfig(os.Stderr, &config) - if err != nil { + if err := util.PrintConfig(os.Stderr, &config); err != nil { level.Error(util_log.Logger).Log("msg", "failed to print config to stderr", "err", err.Error()) } } if config.LogConfig { - err := util.LogConfig(&config) - if err != nil { + if err := util.LogConfig(&config); err != nil { level.Error(util_log.Logger).Log("msg", "failed to log config object", "err", err.Error()) } } @@ -78,13 +75,13 @@ func main() { if err != nil { level.Error(util_log.Logger).Log("msg", "error in initializing tracing. tracing will not be enabled", "err", err) } + defer func() { if trace != nil { if err := trace.Close(); err != nil { level.Error(util_log.Logger).Log("msg", "error closing tracing", "err", err) } } - }() } From 2317870120853b086d006307f070a9977cc4af9d Mon Sep 17 00:00:00 2001 From: michaelgrigoryan25 <56165400+michaelgrigoryan25@users.noreply.github.com> Date: Fri, 10 Jun 2022 14:15:52 +0000 Subject: [PATCH 2/2] cmd/loki: fixed a typo --- cmd/loki/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/loki/main.go b/cmd/loki/main.go index b81470666a5d0..6a23496801d70 100644 --- a/cmd/loki/main.go +++ b/cmd/loki/main.go @@ -93,7 +93,7 @@ func main() { // Start Loki t, err := loki.New(config.Config) - util_log.CheckFatal("initialising loki", err, util_log.Logger) + util_log.CheckFatal("initializing loki", err, util_log.Logger) if config.ListTargets { t.ListTargets()