Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

renderMetrics() doesn't return slices to pool #1799

Closed
shanson7 opened this issue Apr 25, 2020 · 0 comments
Closed

renderMetrics() doesn't return slices to pool #1799

shanson7 opened this issue Apr 25, 2020 · 0 comments
Labels
bug

Comments

@shanson7
Copy link
Collaborator

shanson7 commented Apr 25, 2020 •
edited
Loading

Describe the bug

When processing a render request executePlan is called with a copy of the plan. When plan.Clean() is called we are cleaning a plan with an empty dataMap. Additionally, plan.Run() needs to be a pointer receiver to update the dataMap member.

Working on a PR that addresses this.
@shanson7 shanson7 added the bug label Apr 25, 2020
@shanson7 shanson7 changed the title renderMetrics() doesn't returns slices to pool renderMetrics() doesn't return slices to pool Apr 25, 2020
@Dieterbe Dieterbe mentioned this issue Apr 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dieterbe @shanson7