Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

update sarama to latest tag relase. fixes compression handling #428

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Dec 20, 2016

handling of compression was fixed in Sarama back in August, this is also when the latest tag was cut (v1.10.1).

@Dieterbe
Copy link
Contributor

This should be tested like so:

  • launch a docker stack, and have fakemetrics send metrics to kafka-mdm
  • verify that writing in snappy and gzip from the get go works (visualize the data with fake-metrics-data dashboard and verify ingestion via MT dashboard) . spin up a stack a new for each experiment. make sure docker launches new containers
  • verify that you can start writing uncompressed, then kill fakemetrics and restart with snappy and gzip (all within 1 docker run)

I have done these tests in the past and still hit issues
IBM/sarama#698 (comment)

@woodsaj
Copy link
Member Author

woodsaj commented Dec 20, 2016

I have already tested this in raintank-docker using fakemetrics. everything works as expected.

@Dieterbe Dieterbe merged commit 2715709 into master Dec 20, 2016
@woodsaj woodsaj deleted the updateSarama branch December 21, 2016 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants