Upgrade dskit and fix incorrect caller information on logs emitted with SpanLogger
#9596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Helm CI failure is due to the issues fixed in grafana/helm-charts#3357 |
charleskorn
requested review from
stevesg,
grafanabot and
a team
as code owners
1 task
lamida
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR upgrades dskit to include the following changes:
ReusableGoroutinesPool: Fix datarace onClosedskit#607This PR also modifies Mimir's logging configuration to make use of the new
SpanLogger-awareCallerimplementation added in grafana/dskit#604. This fixes the issue where logs emitted with aSpanLoggerhavecaller=spanlogger.go:xxxrather than the true caller.I don't think these changes are worthy of a changelog entry given they are largely useful for engineers working on Mimir rather than operators or users of Mimir.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.