Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only validate existing settings #4459

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

vadimkerr
Copy link
Member

@vadimkerr vadimkerr commented Jun 4, 2024

What this PR does

Only validate live settings in AVAILABLE_NAMES to avoid issues when a live setting is renamed (one of the settings was renamed in #4287 earlier)

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@vadimkerr vadimkerr added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Jun 4, 2024
@vadimkerr vadimkerr marked this pull request as ready for review June 4, 2024 18:39
@vadimkerr vadimkerr requested a review from a team June 4, 2024 18:39
@vadimkerr vadimkerr enabled auto-merge June 4, 2024 18:53
@vadimkerr vadimkerr added this pull request to the merge queue Jun 4, 2024
Merged via the queue into dev with commit f40634a Jun 4, 2024
27 checks passed
@vadimkerr vadimkerr deleted the vadimkerr/validate-existing-settings branch June 4, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants