New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings for suspect configs #244

Closed

joe-elliott opened this issue Oct 21, 2020 · 0 comments · Fixed by #294

Member

joe-elliott commented Oct 21, 2020

We should't stop a user from creating certain configs, but we do want to warn them. Two that come to mind

If ingester.CompleteBlockTimeout < maintenance cycle then a user may receive 404s between the time the ingesters have flushed a trace and the querier is aware of the new block
If compactor.CompactedBlockRetention < maintenance cycle then the queriers and compactors may attempt to read a block that no longer exists

dgzlopes mentioned this issue

Add warnings for suspect configurations #294

Merged

3 tasks

joe-elliott closed this as completed in #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment