Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 backend logs "unsupported value type" #381

Closed
joe-elliott opened this issue Nov 30, 2020 · 0 comments · Fixed by #383
Closed

s3 backend logs "unsupported value type" #381

joe-elliott opened this issue Nov 30, 2020 · 0 comments · Fixed by #383
Labels
good first issue Good for newcomers

Comments

@joe-elliott
Copy link
Member

Describe the bug
In a number of places the s3 backend logs "unsupported value type" b/c it's being passed a struct. For example:

https://github.com/grafana/tempo/blob/master/tempodb/backend/s3/s3.go#L191

Review the code and pass an appropriate value here. Perhaps size.Size? Also note that this happens in multiple places so please try to find and correct each one.

To Reproduce
Steps to reproduce the behavior:

  1. Use the S3 backend.

Expected behavior
Actual size in bytes to be logged.

Environment:
N/A

Additional Context

@joe-elliott joe-elliott added the good first issue Good for newcomers label Nov 30, 2020
@alexissellier alexissellier mentioned this issue Nov 30, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant