Query compacted blocks that fall within 2 * BlocklistPoll #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <annanayagarwal@gmail.com>
annanay25
requested review from
achatterjee-grafana,
dgzlopes,
joe-elliott and
mdisibio
as code owners
|
Internally we discussed the possibility of deleting the Would be happy to discuss and come up with an alternate setting / option that can replace both the polling and retention! |
joe-elliott
reviewed
Mar 10, 2021
achatterjee-grafana
suggested changes
Mar 10, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
approved these changes
Mar 11, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Search blocks that have been compacted within
2 * BlocklistPoll.This was added because we were inadvertently skipping some blocks from search due to the nature of query sharding and blocklist polling in our architecture.
For a complete explanation do check the comment in the issue linked below!
Which issue(s) this PR fixes:
Fixes #565
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]