Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for GCP configuration. #595

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Added docs for GCP configuration. #595

merged 1 commit into from
Mar 16, 2021

Conversation

Whyeasy
Copy link
Contributor

@Whyeasy Whyeasy commented Mar 16, 2021

Signed-off-by: Whyeasy Whyeasy@users.noreply.github.com

What this PR does:

  • Fixed a typo in the config example regarding gcs.
  • Added a small description which IAM policies should be in place for the service account.

Signed-off-by: Whyeasy <Whyeasy@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -9,10 +9,19 @@ GCS backend is configured in the storage block. Tempo requires a dedicated bucke
storage:
trace:
backend: gcs # store traces in gcs
s3:
gcs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@joe-elliott joe-elliott merged commit f7093f5 into grafana:master Mar 16, 2021
@Whyeasy Whyeasy deleted the update-gcs-docs branch March 17, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants