Rename CLI flag: --storage.trace.maintenance-cycle to --storage.trace.blocklist_poll

[yvrhdn]

Describe the bug
The CLI has a flag --storage.trace.maintenance-cycle

tempo/modules/storage/config.go

Line 34 in c61b678

f.DurationVar(&cfg.Trace.BlocklistPoll, util.PrefixConfig(prefix, "trace.maintenance-cycle"), DefaultBlocklistPoll, "Period at which to run the maintenance cycle.")

But in the YAML config this flag corresponds with storage.trace.blocklist_poll

tempo/tempodb/config.go

Lines 30 to 31 in 9485f96

	BlocklistPoll time.Duration `yaml:"blocklist_poll"`
	BlocklistPollConcurrency uint `yaml:"blocklist_poll_concurrency"`

Changing this will be a breaking change.

Expected behavior
Name of YAML config options and CLI flags match with each other.

[joe-elliott]

I'd prefer going the other way and rename the cli option. It will cause less headache and I think the name makes more sense.

[yvrhdn]

Sure, I must have misread your comment. Agree blocklist_poll is better since this is the only thing we do.