Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet/microservices: create separate configmap for overrides #875

Closed
yvrhdn opened this issue Aug 13, 2021 · 1 comment · Fixed by #896
Closed

jsonnet/microservices: create separate configmap for overrides #875

yvrhdn opened this issue Aug 13, 2021 · 1 comment · Fixed by #896
Labels
good first issue Good for newcomers

Comments

@yvrhdn
Copy link
Member

yvrhdn commented Aug 13, 2021

Is your feature request related to a problem? Please describe.
The current microservices Jsonnet library creates a single configmap per component which contains both the Tempo config and the overrides. This spreads out the overrides configuration, which is updated more often.

We'd like to combine all the overrides in a single configmap which is mounted by the components that need it (distributors, ingesters and compactors). This way only this configmap needs to be managed.

Describe the solution you'd like
Create a new configmap (e.g. tempo-overrides?) that contains all the overrides information.

Describe alternatives you've considered
We can also not do this ofc.

Additional context

For example: this if how the distributor configmap is created right now:

tempo_distributor_configmap:
configMap.new('tempo-distributor') +
configMap.withData({
'tempo.yaml': k.util.manifestYaml($.tempo_distributor_config),
}) +
configMap.withDataMixin({
'overrides.yaml': k.util.manifestYaml({
overrides: $._config.overrides,
}),
}),

And this is how it is mounted:

deployment.mixin.spec.template.spec.withVolumes([
volume.fromConfigMap(tempo_config_volume, $.tempo_distributor_configmap.metadata.name),
]),

If we change how the overrides.yaml is mounted, we'll have to update the Tempo config as well:

overrides: {
per_tenant_override_config: '/conf/overrides.yaml',
},

@yvrhdn yvrhdn changed the title jsonnet/microservices: create separate configmap for overrides.yaml jsonnet/microservices: create separate configmap for overrides Aug 13, 2021
@yvrhdn
Copy link
Member Author

yvrhdn commented Aug 16, 2021

This can be a fun issue if you want to learn more about kubernetes and jsonnet 🙂

To try out this jsonnet library locally, you can use the microservices example in example/tk: https://github.com/grafana/tempo/tree/main/example/tk

@yvrhdn yvrhdn added the good first issue Good for newcomers label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant