Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix propagation of page timeout #1033

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix propagation of page timeout #1033

merged 3 commits into from
Sep 18, 2023

Commits on Sep 14, 2023

  1. Fix page timeout propagation 

    The timeout to the underlying frame manager and frames that page
relied on was not being propagated if page.setDefaultTimeout or
page.setDefaultNavigationTimeout were being called.

This fix ensures that the correct timeout structure is passed to the
underlying objects that the page relies on.

Closes: #940
    @ankur22
    ankur22 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    aea4dc5 View commit details
    Browse the repository at this point in the history

  2. Add a test to ensure that timeout is propagated 

    This tests ensures that the timeout that is set in page is propagated
to the underlying objects (frame manager and frame).

There is one issue which is that the timeout is set in milliseconds but
later it is translated into a second. This needs to be resolved in a
new PR.
    @ankur22
    ankur22 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6441d3f View commit details
    Browse the repository at this point in the history

  3. Add a test to ensure that timeout is propagated 

    This tests ensures that the timeout that is set in browserContext is
propagated to the underlying objects (frame manager and frame).
    @ankur22
    ankur22 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    75ec8a1 View commit details
    Browse the repository at this point in the history