Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predefined network profiles #1098

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Add predefined network profiles #1098

merged 6 commits into from
Nov 15, 2023

Commits on Nov 15, 2023

  1. Add NetworkProfiles

    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e4a672a View commit details
    Browse the repository at this point in the history

  2. Move NetworkProfile type to new file 

    This type now feels like it should live closer to where the predefined
network profiles have been defined.
    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    111a5d1 View commit details
    Browse the repository at this point in the history

  3. Add slow 3g and fast 3g network profiles 

    These are common network profiles which are used in various chromium
based browsers. It feels like it's a safe bet that these will be the
most widely used network profiles. We intend to add more once we have a
clearer idea of what.
    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    021842c View commit details
    Browse the repository at this point in the history

  4. Refactor throttle.js to use slow 3g 

    Instead of defining a custom network profile, use the predefined one
(slow 3g). This serves as a good example as to how to work with
predefined network profiles.
    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f2cd9dd View commit details
    Browse the repository at this point in the history

  5. Add no throttling network profile 

    This will be useful when a user may want to disable the network
throttling half way through a test.
    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    15f06c9 View commit details
    Browse the repository at this point in the history

  6. Add comments on predefined profile numbers 

    This was copied from https://stackoverflow.com/questions/48367042/in-chrome-dev-tools-what-is-the-speed-of-each-preset-option-for-network-throttl
which outlined what the numbers mean when calculating the download and
upload throughputs. We can use this to helps us create our own profiles
when we need.
    @ankur22
    ankur22 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    884e4b9 View commit details
    Browse the repository at this point in the history