Fix NPE on NavigateFrame #1106
Merged
Fix NPE on NavigateFrame #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
approved these changes
Nov 20, 2023
The newDocument field for a navigation event can be nil if the navigation happens within the same document.
ankur22
force-pushed
the
fix/frame-manager-npe
branch
from
57a7e95
to
bc1500e
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a possible NPE in FrameManager.NavigateFrame's event handler to wait for the
navigationevent.The newDocument field for a navigation event can be nil if the navigation happens within the same document.
Why?
Bug.
Checklist
Related PR(s)/Issue(s)
Closes #1105