Refactor query #1107
Merged
Refactor query #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor allows us to work with the injected querySelector in a more dynamic way by allowing us to provide the strict argument programmatically instead of it being hard coded.
This will allow us to pass in the strict flag so that when necessary we can enable strict mode. This change will be useful when it comes to working with APIs which need to query for a single unique element only and otherwise fail, usually with the locator API.
ankur22
force-pushed
the
refactor/query
branch
from
da95be1
to
8f949c6
Compare
inancgumus
approved these changes
Nov 23, 2023
ankur22
added a commit
that referenced
this pull request
Nov 23, 2023
ankur22
force-pushed
the
refactor/query
branch
from
d7f3f53
to
a9cb198
Compare
inancgumus
pushed a commit
that referenced
this pull request
Dec 6, 2023
inancgumus
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It refactors and updates the query API for
elementHandle,frameandpageso that we can enablestrictmode. The change is internal only and doesn't affect the public API.Why?
The change is required so that in the future when we work on an API (such as
locator) that needs to work withquerybut allowstrictmode on.Checklist
Related PR(s)/Issue(s)
Updates: #981