Remove the setInputFiles os.read support #1244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removing the support for
setInputFiles
to read off of the filesystem with the os package.Why?
We do not want k6 to be able to read anything off of a filesystem that it shouldn't be reading. Instead anyone wishing to work with files on the filesystem should look to use the built in experimental fs module. The fs module abstracts away the detail of how it loads the required file for when working in a remote environment. It also reduces the risk of OOMs. A simple example can be found below:
Example working with `setInputFiles` and the fs module
Checklist
Related PR(s)/Issue(s)