Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version #844

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove version #844

merged 1 commit into from
Apr 4, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Apr 3, 2023

There's no longer any need for version in the k6-browser module, since we want users to directly work with the k6 release, and so we would prefer it if they referenced which version of k6 they are running instead of which version of k6-browser module they are working with.

@ankur22 ankur22 added the breaking PRs that need to be mentioned in the breaking changes section of the release notes label Apr 3, 2023
@ankur22 ankur22 added this to the v0.9.0 milestone Apr 3, 2023
@ankur22 ankur22 requested review from inancgumus and ka3de April 3, 2023 12:48
@ankur22 ankur22 self-assigned this Apr 3, 2023
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There's no need for version as we want users to directly work with the
k6 release, and so we would prefer it if they referenced which version
of k6 they are running instead of which version of k6-module they are
working with.
@ankur22 ankur22 merged commit 710e616 into main Apr 4, 2023
@ankur22 ankur22 deleted the remove/version branch April 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants