Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser module Version #923

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jun 7, 2023

We should have removed the exported field after the following change: 710e616. This PR removes the Version field for good.

@inancgumus inancgumus self-assigned this Jun 7, 2023
@inancgumus inancgumus added this to the v0.11.0 milestone Jun 7, 2023
@inancgumus inancgumus requested a review from ka3de June 7, 2023 12:41
@inancgumus inancgumus added bug Something isn't working breaking PRs that need to be mentioned in the breaking changes section of the release notes labels Jun 7, 2023
We should have removed the exported field after the following change:
710e616. This PR removes the Version for good.
@inancgumus inancgumus force-pushed the remove/browser-module-version branch from afd1811 to c40d9d7 Compare June 7, 2023 12:45
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inancgumus inancgumus merged commit 92ac6b7 into main Jun 9, 2023
@inancgumus inancgumus deleted the remove/browser-module-version branch June 9, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking PRs that need to be mentioned in the breaking changes section of the release notes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants