Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement generic Apply method using dynamic client's apply #77

Open
pablochacin opened this issue Oct 24, 2022 · 1 comment
Open

Re-implement generic Apply method using dynamic client's apply #77

pablochacin opened this issue Oct 24, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pablochacin
Copy link
Contributor

Presently the Apply method provided by the generic API is implemented as a Create from a yaml file. This is not consistent with the experience that users may have with thekubectl apply command that allows both creating new resources or modifying existing resources.

Starting with v1.25 the dynamic client now offers an Apply method which implements the desired functionality, allowing both the creation or the modification of resources.

Therefore, it would be convenient for the sake of consistency and convenience to re-implement the Apply method in the generic API using this newly provided Apply method in the dynamic client.
@pablochacin pablochacin added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2022
@pablochacin pablochacin mentioned this issue Nov 14, 2022
Closed
@pablochacin pablochacin mentioned this issue Dec 1, 2022
Merged
@dgzlopes
Copy link
Member

Can we close this one? @pablochacin 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pablochacin @dgzlopes