Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better API for HTTP Headers #101

Closed
codebien opened this issue Feb 7, 2023 · 2 comments · Fixed by #147
Closed

Better API for HTTP Headers #101

codebien opened this issue Feb 7, 2023 · 2 comments · Fixed by #147
Labels
enhancement New feature or request

Comments

@codebien
Copy link
Contributor

codebien commented Feb 7, 2023

k6 does not support the most used case of the current API for setting the custom HTTP Headers, which is the Cortex authentication. See grafana/k6#2904 for details.

The suggestion is to deprecate the current API and replace it with a fixed environment variable name supported by k6. (e.g. K6_PROMETHEUES_RW_HTTP_HEADERS and use the value for the key-values binding. k6 uses the same approach for the tags' customization in the tagsInfluxDBv1 output.

K6_PROMETHEUES_RW_HTTP_HEADERS=X-Scope-OrgID:<org>,X-ANOTHER_HEADER:val
@lanore78
Copy link

lanore78 commented Feb 7, 2023

Hi @codebien

It would be really great if you let me know the estimated time for this issue to be released.
We've been researching new performance test tools that can replace LoadRunner, and currently K6 is the most likely tools to replace LoadRunner.

@codebien
Copy link
Contributor Author

codebien commented Feb 7, 2023

Hi @lanore78,

It would be really great if you let me know the estimated time for this issue to be released.

We don't have an estimated time for this, it could be considered in the next weeks. If you want to speed up the process, you may consider contributing with a PR. The required code should be doable for an external contributor with a bit of Go knowledge.

sysedwinistrator added a commit to sysedwinistrator/xk6-output-prometheus-remote that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants