Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A line in the example errors out ... funny #12

Open
mstoykov opened this issue Aug 31, 2022 · 0 comments
Open

A line in the example errors out ... funny #12

mstoykov opened this issue Aug 31, 2022 · 0 comments

Comments

@mstoykov
Copy link
Contributor 

  addrs: __ENV.REDIS_ADDRS.split(",") || new Array("localhost:6379"), // in the form of "host:port", separated by commas

will give you TypeError: Cannot read property 'split' of undefined or null so it is:

  1. both confusing what happened instead of tell you that you haven't set REDIS_ADDRS
  2. the "defaulting" to localhost:6379 is not working.

I don't think there is a particular reason to have this take multiple addresses in the example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mstoykov