Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle options as goja.Object directly as opposed to exported map[string]interface{} #27

Open
oleiade opened this issue Nov 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@oleiade
Copy link
Member

oleiade commented Nov 2, 2023

At the moment we parse the options provided by the user in a two step process:

  1. First, export the options goja.Object to a map[string]interface{}
  2. Only then, extract and handle the options from that resulting map

This leads to what we think to be unnecessary json marshalling/unmarshalling to ensure correctness and consistency when working on a goja.Object directly might have been easier.

We probably should make a pass over the options handling code to operate that replacement 👍🏻

@oleiade oleiade added the enhancement New feature or request label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant