Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency #404

Closed
alexbjorlig opened this issue Oct 31, 2022 · 4 comments
Closed

Circular dependency #404

alexbjorlig opened this issue Oct 31, 2022 · 4 comments

Comments

@alexbjorlig
Copy link

Am I the only one who gets this error when building?

Circular dependency: ../../node_modules/graphql-request/dist/index.js -> ../../node_modules/graphql-request/dist/graphql-ws.js -> ../../node_modules/graphql-request/dist/index.js
@jasonkuhrt
Copy link
Member

What tool are you using that leads to this error?

@jonkoops
Copy link
Collaborator

FYI this is likely Rollup emitting this warning.

@jasonkuhrt
Copy link
Member

I see this is coming from our ws module. Speaking of that @jonkoops there's a lot of duplication in that module from some other ws library. It would be nice to ditch all that if possible, but I haven't investigated recently.

@jonkoops
Copy link
Collaborator

Yeah, perhaps this is something we can get to for the next version. I am going to try and get all the open bugs resolved as best I can, then we should take a moment and decide if we want to make some API changes and improvements before the major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants