From b156214b99d51bd573dc282707bb14a562457a1f Mon Sep 17 00:00:00 2001
From: Mattias Reichel <mattias.reichel@gmail.com>
Date: Wed, 22 Nov 2023 20:25:39 +0100
Subject: [PATCH 1/2] Modernise the build of grails-uber-test-suite. Remove
 non-existing tests from isolated tests. Remove duplication to make it easier
 to maintain.

---
 grails-test-suite-uber/build.gradle | 100 ++++++++++++----------------
 1 file changed, 44 insertions(+), 56 deletions(-)

diff --git a/grails-test-suite-uber/build.gradle b/grails-test-suite-uber/build.gradle
index 25bebe1a468..7d1c3a6ad6c 100644
--- a/grails-test-suite-uber/build.gradle
+++ b/grails-test-suite-uber/build.gradle
@@ -1,5 +1,5 @@
 configurations.testCompileClasspath {
-    exclude module: "grails-plugin-testing"
+    exclude module: 'grails-plugin-testing'
 }
 
 dependencies {
@@ -86,66 +86,54 @@ dependencies {
     }
 }
 
-test {
-     maxParallelForks = isCiBuild ? 2 : 4
-     forkEvery = isCiBuild ? 25 : 100
-     if(!isCiBuild) {
-         maxHeapSize = '1024m'
-     }
-     excludes = [
-         "**/grails/test/PersonTests.class",
-         "**/rest/render/**/*Spec.class",
-         "**/*TestCase.class",
-         "**/DataSourceGrailsPluginTests",
-         "**/DefaultGrailsControllerClassTests.class",
-         "**/GrailsUnitTestCaseTests.class",
-         "**/SetupTeardownInvokeTests.class",
-         "**/TestMixinSetupTeardownInvokeTests.class",
-         "**/UrlMappingsTestMixinTests.class",
-         "**/WebUtilsTests.class",
-         "**/RestfulControllerSpec.class",
-         "**/ResourceAnnotationRestfulControllerSpec.class",
-         "**/TestingValidationSpec.class",
-         "**/CascadingErrorCountSpec"
-     ]
-}
-
-task isolatedTestsOne(type:Test) {
-    includes = [
-        "**/DataSourceGrailsPluginTests.class",
-        "**/GrailsUnitTestCaseTests.class",
-        "**/WebUtilsTests.class"
-    ]
-}
-
-task isolatedTestsTwo(type:Test) {
-    maxParallelForks = 1
-    forkEvery = 100
-    includes = [
-        "**/UrlMappingsTestMixinTests.class",
-        "**/SetupTeardownInvokeTests.class",
-        "**/TestMixinSetupTeardownInvokeTests.class"
+def isolatedTestPatterns = [
+    isolatedTestsOne: [
+        'org.grails.core.DefaultGrailsControllerClassSpec',
+        'org.grails.web.util.WebUtilsTests'
+    ],
+    isolatedTestsTwo: [
+        'UrlMappingsTestMixinTests',
+        'SetupTeardownInvokeTests',
+        'TestMixinSetupTeardownInvokeTests'
+    ],
+    isolatedRestRendererTests: [
+        '*.rest.render.*Spec'
+    ],
+    isolatedPersonTests: [
+        'org.grails.validation.TestingValidationSpec',
+        'org.grails.validation.CascadingErrorCountSpec'
+    ],
+    isolatedRestfulControllerTests: [
+        'RestfulControllerSpec',
+        'ResourceAnnotationRestfulControllerSpec'
     ]
-}
-
-task isolatedRestRendererTests(type:Test) {
-    includes = ['**/rest/render/**/*Spec.class']
-}
+]
 
-task isolatedDefaultGrailsControllerClassTests(type: Test) {
-    includes = ['**/DefaultGrailsControllerClassTests.class']
+tasks.withType(Test).configureEach {
+    maxParallelForks = isCiBuild ? 2 : 4
+    forkEvery = isCiBuild ? 25 : 100
+    if(!isCiBuild) {
+        maxHeapSize = '1024m'
+    }
 }
 
-task isolatedPersonTests(type: Test) {
-    includes = ['**/grails/test/PersonTests.class',
-                "**/TestingValidationSpec.class",
-                "**/CascadingErrorCountSpec"
-                ]
+tasks.named('test', Test) {
+    filter.excludePatterns = isolatedTestPatterns.values().flatten()
+    dependsOn(provider {
+        tasks.findAll({
+            isolatedTestPatterns.containsKey(it.name)
+        })
+    })
 }
 
-task isolatedRestfulControllerTests(type:Test) {
-    includes = ["**/RestfulControllerSpec.class",
-        "**/ResourceAnnotationRestfulControllerSpec.class"]
+isolatedTestPatterns.keySet().each { taskName ->
+    tasks.register(taskName, Test) {
+        group = 'verification'
+        filter.includePatterns = isolatedTestPatterns[taskName]
+    }
 }
 
-test.dependsOn isolatedPersonTests, isolatedTestsOne, isolatedTestsTwo, isolatedRestRendererTests, isolatedDefaultGrailsControllerClassTests, isolatedRestfulControllerTests
+tasks.named('isolatedTestsTwo', Test) {
+    maxParallelForks = 1
+    forkEvery = 100
+}
\ No newline at end of file

From a0a7f2faad93a4533ee9e006edee7b71e75fdec5 Mon Sep 17 00:00:00 2001
From: Mattias Reichel <mattias.reichel@gmail.com>
Date: Wed, 22 Nov 2023 21:00:42 +0100
Subject: [PATCH 2/2] Add packages to patterns.

---
 grails-test-suite-uber/build.gradle | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/grails-test-suite-uber/build.gradle b/grails-test-suite-uber/build.gradle
index 7d1c3a6ad6c..26816e39b5f 100644
--- a/grails-test-suite-uber/build.gradle
+++ b/grails-test-suite-uber/build.gradle
@@ -92,9 +92,9 @@ def isolatedTestPatterns = [
         'org.grails.web.util.WebUtilsTests'
     ],
     isolatedTestsTwo: [
-        'UrlMappingsTestMixinTests',
-        'SetupTeardownInvokeTests',
-        'TestMixinSetupTeardownInvokeTests'
+        'grails.test.mixin.UrlMappingsTestMixinTests',
+        'grails.test.mixin.SetupTeardownInvokeTests',
+        'grails.test.mixin.TestMixinSetupTeardownInvokeTests'
     ],
     isolatedRestRendererTests: [
         '*.rest.render.*Spec'
@@ -104,8 +104,8 @@ def isolatedTestPatterns = [
         'org.grails.validation.CascadingErrorCountSpec'
     ],
     isolatedRestfulControllerTests: [
-        'RestfulControllerSpec',
-        'ResourceAnnotationRestfulControllerSpec'
+        'grails.test.mixin.RestfulControllerSpec',
+        'grails.test.mixin.ResourceAnnotationRestfulControllerSpec'
     ]
 ]