fix(compiler): Provide appropriate error during invalid array access #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Dec 19, 2022
phated
approved these changes
Dec 22, 2022
peblair
reviewed
Dec 23, 2022
| ), | ||
| Expression.Block.make( | ||
| wasm_mod, | ||
| gensym_label("IndexNotSimpleInteger"), |
There was a problem hiding this comment.
I feel like this is a symptom that XX.toNumber should reduce its argument to the smallest containing integer, rather than be a no-op...
There was a problem hiding this comment.
I think how it works now is correct (since the flexibility is the point of Number), but we should definitely have a utility that does let you round/truncate. It gets kinda hairy for floats, since we support bigints. My basic math tells me that the worst case conversion of a float64 to a bigint would be a bigint with 16 limbs, so maybe not actually so bad.
That said though, I could see us converting whole numbers to ints. 3.0 becoming 3, that sort of thing.
But yeah, food for thought.
peblair
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a potential non-integer or heap-allocated index for an array get/set may not result in an error. It also provides a better error for non-integer indexes.