Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "new attribute" modal for editing a person is too small #470

Open
gustavi opened this issue Jul 17, 2024 · 4 comments
Open

The "new attribute" modal for editing a person is too small #470

gustavi opened this issue Jul 17, 2024 · 4 comments

Comments

@gustavi
Copy link
Contributor

gustavi commented Jul 17, 2024

Description

The "new attribute" modal for editing a person is too small and hard to use. The select do not display more than 2 full options.

image

How to reproduce

  • Go to a person profile (/person/I[N])
  • Edit (bottom right)
  • Attributes tab
  • "+" button

Proposed fixes

  1. Making the modal taller
  2. Allow the select to go beyond the modal

Additional information

  • Firefox 115
  • 1920x1080
  • Gramps Web Frontend 24.7.0
@DavidMStraub
Copy link
Member

Right. But no need to enlarge the modal, just need to set fixedMenuPosition on the mwc-select.

@DavidMStraub DavidMStraub added the bug Something isn't working label Jul 19, 2024
@DavidMStraub
Copy link
Member

Turns out this can't be fixed easily with MWC, see material-components/material-web#832.

The solution is to migrate to md-filled-select which has a menuPositioning attribute, see https://material-web.dev/components/select/. But is more work.

@DavidMStraub
Copy link
Member

Also true for place types:

#481 (comment)

@m-breitbach
Copy link

m-breitbach commented Aug 9, 2024

I observed that, if the dropdown menu opens downwards and is truncated, the whole modal can be scrolled down (this makes it usable at least, even if not super conveniently). In cases where it openes upwards and is truncated (like in place types), no such scrolling becomes availabe.

@DavidMStraub DavidMStraub removed the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants