Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Graph::isEmpty() #59

Closed
clue opened this issue Jul 10, 2013 · 1 comment
Closed

Remove Graph::isEmpty() #59

clue opened this issue Jul 10, 2013 · 1 comment
Milestone

Comments

@clue
Copy link
Member

clue commented Jul 10, 2013

Its definition is ambiguous: the current implementation considers a Graph with no vertices as empty, whereas the common (ymmv) interpretation is to check for the number of edges instead.

Once #48 is merged, it should be trivially easy to replace all existing calls to explicitly check for either $graph->getVertices()->isEmpty() or $graph->getEdges()->isEmpty() instead.

@clue clue mentioned this issue Jul 16, 2013
3 tasks
@clue
Copy link
Member Author

clue commented Sep 10, 2013

Fixed via #63.

@clue clue closed this as completed Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant