Graphviz has default graph ID

[clemens-tolboom]

When generating a Graph its name always is 'G' (in svg output it's the title sometimes showed as a web browser tooltip)

The code https://github.com/clue/graph/blob/master/lib/Fhaculty/Graph/GraphViz.php#L285

        $script = ($directed ? 'di':'') . 'graph G {' . self::EOL;

could render a proper ID as defined in http://www.graphviz.org/content/dot-language

Trouble is where to set its name as this has no relation to the graph layout.

Ie adding a label layout attribute like

        $script .= ' label = "Awesome graph"' . self::EOL;

adds a label to the output.

Can we do better?

Relates to #84 + #40

[clue]

Indeed, thanks for bringing this to my attention.

Trouble is where to set its name as this has no relation to the graph layout.

See my comment in PR #40 about how I think we might have a misunderstanding about layout attributes.

IMO, once PR #40 lands, it would be desirable to support something along the lines of this:

$graph->getLayout()->setAttribute('id', 'Awesome graph');

[clemens-tolboom]

You are right ... setting the id will fix it.

[clue]

setting the id will fix it.

That's good news :)

I still think we should add an option to change the default graph id nevertheless, so I've added a new ticket for the upcoming graphviz repo: graphp/graphviz#3.