Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createAttestation is unnecessarily async #36

Open
snario opened this issue Jul 15, 2020 · 0 comments
Open

createAttestation is unnecessarily async #36

snario opened this issue Jul 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@snario
Copy link
Contributor

snario commented Jul 15, 2020

common-ts/packages/common-ts/src/attestations/attestations.ts

Line 32 in 9209c47

export const createAttestation = async (

Minor nitpick but seems like this does not need to be async.
@snario snario changed the title createAttestations is unnecessarily async createAttestation is unnecessarily async Jul 15, 2020
@Jannis Jannis added the enhancement New feature or request label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jannis @snario