Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong event order on same block from Aave clone V2 on Godwoken chain #3878

Closed
Roger-RumbleFish opened this issue Aug 26, 2022 · 3 comments
Closed

Comments

@Roger-RumbleFish
Copy link

Roger-RumbleFish commented Aug 26, 2022

Here is my subgraph repo -> https://github.com/Roger-RumbleFish/Subgraph-test

the issue is between createOrLoadReserve and CollateralConfigurationChangedHandler

they should be called in order

  1. createOrLoadReserve (all 6 tokens)
  2. CollateralConfigurationChangedHandler (all 6 tokens)

Unfortunately some of the events are called not in correct order. Because my events are depend on each other i have null values for wBTC reserve

image

the problem is between blocks 72543 -> 72544 when i deployed the contracts

When i make getLogs call i get them in correct order

image (9)

if you need the rpc for godwoken mainnet here it is -> https://v1.mainnet.godwoken.io/rpc

to run it

  1. yarn
  2. docker-compose up
  3. yarn rebuild
@azf20
Copy link
Contributor

azf20 commented Sep 1, 2022

Hi - it is not clear to me that there is an ordering issue here, indeed I think there shouldn't be. Can you provide Graph Node logs to clarify the exact order of execution? You can add logging to help with debugging

@Flouse
Copy link

Flouse commented Oct 20, 2022

Hi, @Roger-RumbleFish
Thanks for the bug report.
It was a bug in Godwoken web3-indexer which has been fixed.

PR

[Log's index should index in a block, not transaction]

Releases

@azf20
Copy link
Contributor

azf20 commented Oct 24, 2022

Thanks!

@azf20 azf20 closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants