Fix pagination for 'last' page. #1074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraciunoiu
commented
Dec 15, 2020
| ) | ||
|
|
||
| list_slice_length = list_length | ||
| if max_limit is not None and "last" not in args: |
There was a problem hiding this comment.
Without checking for last here and below, list_slice_length was being set to 4, and after to 0, slicing off reporters 5-8.
Query for last 2 reporters should be getting 7 and 8, but it wasn't getting those correctly.
|
I think this is the doing basically the same thing as the PR I submitted a while ago: #1046 which is still waiting to be merged |
|
@tcleonard thanks for the ping! Looks great, I left a small comment there. Closing in favor of #1046. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paginating from the end of the results, the last items were not returned correctly.
Added a test to showcase the issue.