Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken links to graphene filter documentation (master->latest) #1296

Closed
wants to merge 1 commit into from

Conversation

ppk42
Copy link
Contributor

@ppk42 ppk42 commented Jan 30, 2022

I checked the new links; they work. I'm aware that .../latest is a link that may point to different content in the future. But with master it was the same situation.

@ulgens ulgens self-requested a review February 7, 2022 14:18
Copy link
Collaborator

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that .../latest is a link that may point to different content in the future.

I agree with this. Proper replacement for master is main. Broken links are the result of branch name change.

@ppk42
Copy link
Contributor Author

ppk42 commented Feb 12, 2022

Thank you for the hint. Yes, why not use the most obvious renaming? ;-) Unfortunately, I'm so arragant and deleted my fork :-(. Now I have no idea how to reassign the newly created fork to the PR. So I will close this PR and open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants