fixed broken links to graphene filter documentation (master->main) #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
approved these changes
Feb 12, 2022
|
@ppk42 Thanks for your effort! 🚀 |
|
@ppk42 Do we have the same issue in v2 branch? |
|
@ulgens You are right. V2 is affected too. I've also overseen a possibly wrong link to the github master tree. The master branch still exists but code in the main branch should refer to the main tree, right? I'll add the necessary PR. Thank you for the review. |
ulgens
pushed a commit
that referenced
this pull request
Feb 13, 2022
* fix broken links for the v2 branch v2 brach has broken links to read the docs too I additionally found a link to the git hub master tree, which should be changed to main. * #1295 github link fixed (master->v2) Co-authored-by: Peter Paul Kiefer <dafisppk@gmail.com>
ulgens
pushed a commit
that referenced
this pull request
Feb 13, 2022
* fixed broken links to graphene filter documentation (master->main) * #1295 There is still a wrong link to github The referenced example is in main branch but the link goes to the master branch which still exists. Co-authored-by: Peter Paul Kiefer <dafisppk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of PR #1296. I unfortunatly delete my fork bfore the PR was reviewed and approved and, I had not used the most wanted branch name in the links. And I did not manage it to reassigne the new fork to the former PR #1296.