👽 Use .formatted instead of format_error #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, if someone is able to fix the test I can merge and push a release :) Some of the test failures (with the = Nones missing) are not caused by this PR, but by this fix on graphene, released in |
erikwrede
requested changes
Aug 15, 2022
nikolaik
force-pushed
the
fix/graphql-core-32
branch
from
26158f1 to
7aa2d61
Compare
null default values no more trailing newlines
nikolaik
force-pushed
the
fix/graphql-core-32
branch
from
7aa2d61 to
dc87546
Compare
|
@erikwrede thanks! ❤ |
|
Thank you! 🚀 |
This was referenced Aug 15, 2022
Closed
nikolaik
added a commit
to kindly-ai/graphene-django
that referenced
this pull request
Aug 15, 2022
…ix tests * 👽 Use .formatted instead of format_error * ✅ Fix test with newer graphene null default values (graphql-python/graphene@03277a5) no more trailing newlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops using the deprecated format_error removed in graphql-core v3.2 graphql-python/graphql-core@09ff14f .
GraphqlError.formattedhas been a thing since at least v1.This PR tries to solve the same thing as #1326 and #1320.
Looks like there a missing newline in test output. Not sure if to update the tests or the code.