Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only release on pypi after tests pass #1452

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Only release on pypi after tests pass #1452

merged 1 commit into from
Aug 11, 2023

Conversation

kiendang
Copy link
Collaborator

Context #1448 (comment)

Relevant GHA docs workflow_call, needs

sjdemartini
sjdemartini approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much for adding this! This is the same approach/syntax I used in a frontend package I maintain and it works well there

@firaskafri firaskafri merged commit 720db1f into main Aug 11, 2023
@firaskafri firaskafri deleted the test-before-release branch August 11, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjdemartini sjdemartini sjdemartini approved these changes

@firaskafri firaskafri Awaiting requested review from firaskafri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiendang @sjdemartini @firaskafri