-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Django 2 + in tests #336
Conversation
2 similar comments
I should note that in my previous pull request #335 i added on_delete attribute to all related fields - as this is a required field starting in 2.0 (but supported before) |
Have updated python version in setup.py so that if its python 2 it doesnt try install django 2 |
Now the 2.0 tests are failing because pytest-django has not released a version which supports 2.0 (Coming in version 3.1.3) |
Thanks for your work here! It's looking great so far. It looks like pytest-django 3.1.3 is coming pretty soon, so my vote would be to wait for that and then we can update the If you want to try out their master in the meantime to make sure it doesn't break anything else, that might be a good next move. There's always a chance that updating to their master will cause older python/django versions to break. |
For now, I'm going to steal this bit so we can at least get new PRs passing their builds.
|
Hi @spockNinja |
Foreign keys in Django 2 require an on_delete attribute
Also the field.rel attribute has been deprecated as of Django 2 and is now field.remote_field
I have added a fallback for 1.8
The django docs specifying the changes to field.rel