Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the test build #338

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Conversation

spockNinja
Copy link
Contributor

@spockNinja spockNinja commented Dec 9, 2017

Several PRs are failing for unrelated reasons. Figuring out those reasons and getting the build passing again...

It looks like there is just one issue:

Django 2.0 is released and we aren't ready for that yet. #336 will fix it completely, but for now, we just need to not install 2.0 on python 2.7

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Coverage remained the same at 93.142% when pulling f8a5860 on spockNinja:fix_tests into 24706f5 on graphql-python:master.

@spockNinja
Copy link
Contributor Author

@syrusakbary Our test suites for 2.7 are failing across several outstanding PRs.

#336 is going to get us Django 2.0 supported in full, but it's waiting on an upstream push to pytest. For now, we can get existing PRs fixed back up with just this change.

@syrusakbary syrusakbary merged commit b54e02c into graphql-python:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants