Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize custom type conversion over standard conversions #390

Open
PaulSchweizer opened this issue Apr 13, 2023 · 1 comment
Open

Prioritize custom type conversion over standard conversions #390

PaulSchweizer opened this issue Apr 13, 2023 · 1 comment

Comments

@PaulSchweizer
Copy link
Collaborator

PaulSchweizer commented Apr 13, 2023

As discussed with @erikwrede we have to make sure that we prioritize registered custom type conversions over the defaults.

Example:

This:

from sqlalchemy_utils import JSONType

@convert_sqlalchemy_type.register(JSONType)
def convert_column_to_json(*args, **kwargs):
    return graphene.types.generic.GenericScalar

will result in a JSONString field instead of a GenericScalar

@adiberk
Copy link

adiberk commented Mar 18, 2024

This is pretty important, nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants