How to properly deal with result from Promise.allSettled

[klippx]

I was reading this blog post and looked at the code snippet:

new DataLoader<TeamUserKey, AtlassianAuth | null, string>(
   async (keys) => {
     const results = await Promise.allSettled(
       keys.map(async ({userId, teamId}) => {
         const atlassianAuth = await getAtlassianAuth(userId, teamId)
         const {accessToken: oldToken, refreshToken} = atlassianAuth
         const decodedToken = oldToken && decode(oldToken)
         const now = new Date()
         const inAMinute = Math.floor((now.getTime() + 60000) / 1000)
         if (!decodedToken || decodedToken.exp < inAMinute) {
           const newToken = await getNewToken(refreshToken)
           atlassianAuth.accessToken = newToken
           atlassianAuth.updatedAt = now
           await upsertAtlassianAuth(atlassianAuth)
         }
         return atlassianAuth
       })
     )
     return results.map((r) => r.status === 'fulfilled' && r.value)
   }
)

It looks good to me, but it is the last line that I am concerned about. They apparently want to ignore their errors and cast them to false (I guess they missed a || null). This works in GraphQL, assuming the schema allows a nullable array. But is this really "the way", dataloader community?

What about doing it like this instead?

  return results.map((result) => {
    if (result.status === 'rejected') {
      if (result.reason instanceof Error) {
        return result.reason;
      }

      return new Error(`Rejected with ${JSON.stringify(result.reason)}`);
    }

    return result.value;
  });

The reason for this is because .load doesn't care, it throws as soon at the first sight of trouble anyway. But .loadMany does care and does expect the error to be returned by the batchLoadFn argument.

So, am I right or did I miss something? 🤔