[QUESTION] name is now required in options?

[mdecurtins]

I think there may be an issue introduced by the recent PR #326. The Typescript declaration in index.d.ts is name: string | null, but shouldn't it be name?: string | null, especially if null is the default value if name is not provided in Options?

Typescript (we're using 4.8.4) is suddenly giving me a flood of TS2345 errors saying that my Dataloader instances are missing property 'name' in Options, which is a correct error given the way index.d.ts is written, but these are spurious errors because name is optional and I believe it should be declared as name?: string | null.

Anybody else run into this? Thanks!

[saihaj]

sorry about that will be releasing a patch #331

[mdecurtins]

Awesome, thanks!

[saihaj]

https://github.com/graphql/dataloader/releases/tag/v2.2.1

[ericwei0919]

In release v2.2.2, the DataLoader added below attribute, should this attribute be optional? If this is required one, it would break createDataLoader method of @lifeomic/dynamodb-dataloader which worked with v2.2.1.

name	String	null	The name given to this DataLoader instance. Useful for APM tools.