Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt to pre-release extension support #2361

Open
isidorn opened this issue Dec 9, 2021 · 4 comments
Open

Adopt to pre-release extension support #2361

isidorn opened this issue Dec 9, 2021 · 4 comments

Comments

@isidorn
Copy link

isidorn commented Dec 9, 2021

Hi VS Code PM here 👋

Refs: microsoft/vscode#15756

VS Code now supports pre-release extensions. Docs that should help: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

I know VSCode-graphql has a separate Insiders extension. Ideally you would adopt to our pre-release support and we would deprecate that other extension. VS Code can automatically migrate your existing VSCode-graphql Insiders users to the pre-release version of the extension once you have done the adoption.

Let me know what you think

@acao
Copy link
Member

acao commented Dec 9, 2021

I saw the new --pre option when updating vsce cli recently, it was so exciting! can't wait to try it out and give feedback.

Our users need this badly. I was planning on modifying our workflow to release with this new flag on every merge, and then use atlassian chagesets to cut the stable release from a release PR.

This would do wonders for our users, and allow us to embark on more long term efforts to improve stability, add complex features, etc and even moreso when we merge this repository with the language service/server monorepo.

Thanks so much for adding this feature!

@isidorn
Copy link
Author

isidorn commented Dec 9, 2021

Great, glad you find the feature helpful! Let us know how it goes.

@acao acao transferred this issue from graphql/vscode-graphql Apr 19, 2022
@acao
Copy link
Member

acao commented Apr 19, 2022

@isidorn we have tried, but the lack of support for semver pre-release tags makes it very difficult to support with standard tooling. I still have a plan for how to work around it, but we may need to wait until semver pre-release versions are supported. I can see that there is a custom semver lib in vscode-languageserverclient, perhaps the official semver lib would be easier to support and less maintenance?

@isidorn
Copy link
Author

isidorn commented Apr 20, 2022

@acao thanks for trying to use pre-release support.
You can wait for semver support by the Marketplace but that will not happen this year.

Did you try following the workaround recommendation from this docs https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions
"Because of this we recommend that extensions use major.EVEN_NUMBER.patch for release versions and major.ODD_NUMBER.patch for pre-release versions"

All the extensions we talked to so far have been successful in adopting to pre-release support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants