Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lsp-server] handle syntax highlighting at the LSP level #2851

Open
acao opened this issue Oct 30, 2022 · 0 comments
Open

[lsp-server] handle syntax highlighting at the LSP level #2851

acao opened this issue Oct 30, 2022 · 0 comments
Labels
enhancement lsp-server graphql-language-service-server vscode-graphql-syntax

Comments

@acao
Copy link
Member

acao commented Oct 30, 2022 •
edited
Loading

Current Behavior (if applicable)

All of our code highlighting is provided by static grammar files that are only available to vscode clients

Desired Behavior

We should lean on the LSP to generate code highlitghing rules for us programatically

microsoft/vscode-languageserver-node#367

this will make our code highlighting logic far more testable

yes this would lead to retiring the syntax extension
@acao acao added enhancement lsp-server graphql-language-service-server vscode-graphql-syntax labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement lsp-server graphql-language-service-server vscode-graphql-syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acao