feat: Monaco graphql Completion #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome work, @rebornix ! thank you so much! |
acao
approved these changes
Mar 15, 2020
| @@ -52,6 +53,34 @@ import { | |||
| objectValues, | |||
| } from './autocompleteUtils'; | |||
|
|
|||
| // TODO@acao,rebornix | |||
There was a problem hiding this comment.
ah i see, yes i dont think we need to take step into account, as this context isn't needed in this case
|
going to go ahead and merge this to the working branch! thanks a bunch |
acao
pushed a commit
that referenced
this pull request
Apr 4, 2020
acao
pushed a commit
that referenced
this pull request
Apr 5, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 6, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 6, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 9, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 12, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 13, 2020
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #1421
Had a good discussion offline with @acao about how to incrementally support GraphQL LSP in Monaco and we agreed to implement Completion first, with which we can test the runtime agnostic GraphQL LS and get a good understanding of integration between Monaco and GraphQL LS.
The code is still not demo-ready due to three blockers, which can be resolved later:
GraphQLCacheinitializationCompletionItemKindhttps://github.com/graphql/graphiql/pull/1428/files#diff-6d88bd46b01fdd44682f45d55e5202bdR59