-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Monaco Mode - Phase 2 - Mode & Worker #1459
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 58.98% 58.80% -0.18%
==========================================
Files 60 60
Lines 3023 3042 +19
Branches 796 811 +15
==========================================
+ Hits 1783 1789 +6
- Misses 1194 1207 +13
Partials 46 46
Continue to review full report at Codecov.
|
5f2e990
to
ae29b0a
Compare
87bd8b2
to
f3a69f2
Compare
a8e5f1e
to
9ef2d47
Compare
"typings": "dist/monaco.contribution.d.ts", | ||
"contributors": [ | ||
{ | ||
"name": "Peng Lyu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebornix gave you credit since you created most of the features! haha
f692a1c
to
5654c58
Compare
c9bbac2
to
62a22b4
Compare
to preview the monaco branch, append the slash /monaco path: |
70614c0
to
ae45033
Compare
d1b1cc4
to
279c327
Compare
{ | ||
"name": "monaco-graphql", | ||
"description": "full service, official monaco mode for GraphQL", | ||
"version": "2.3.4-alpha.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can decide what this should be before we release a stable version, but I'll probably just change it to something like 0.1.0 for the first pre-release
279c327
to
10525dc
Compare
Co-authored-by: Rikki Schulte <rikki.schulte@gmail.com>
10525dc
to
8722551
Compare
For the second phase, we will implement a monaco mode and worker, and we only support completion and maybe diagnostics. Summarized more completely in #1445
Outcomes
packages/monaco-graphql
andexamples/monaco-webpack
Todo
Another PR?
Scoped to only completion for now. Other features will be iterative
How to Develop/Test
yarn --force
yarn tsc --watch
(one time)yarn build-ts
examples/monaco-graphql
:yarn start